Sun May 22 00:51:30 EDT 2005 rsc
Thanks for taking a look at these. A few small things to fix:
1. In troff/t10.c you call strncpy without a third argument.
Not sure why building troff wouldn't have caught that.
2. Please don't use strncpy(dst, src, n). Use strecpy(dst, dst+n, src).
The difference between the two is that strecpy promises to NUL-terminate
dst, while strncpy does not.
3. In awd, you changed the prints into a series of fprints. This is
not okay -- these are control messages and they need to arrive at acme
as a single write. Use smprint if you need to.
Thanks again for taking care of these. I look forward to another patch.
Russ
|